Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kbauer/setup nr backend tests #164

Merged
merged 8 commits into from
Dec 16, 2024
Merged

Conversation

kb-newrelic
Copy link
Contributor

@kb-newrelic kb-newrelic commented Dec 16, 2024

Summary

  • Setup new e2e test which exports data to NR (instead of using a mock backend). For the lack of better terminology, I decided to call these new tests 'slow e2e' and the existing mock backend tests 'fast e2e'. Open to changing this (including the dir/file structure).
  • Slow tests run on a dedicated nightly CI build (ci_nightly.yaml) using main and can be manually triggered with any branch/commit
  • Main work of this PR was generalizing the current test setup:
    • moved charts to separate dir (test/charts) to allow reuse of charts but also not tie charts to specific test
    • define second chart (test/charts/nr_backend) with NR as backend
    • move duplicate test logic into various types of util functions (test/e2e/util). Open to rehauling this, just a first attempt.
  • Necessary secrets (ingest key, api key, staging urls,...) are passed around as env vars and then turned into k8s Secrets

Misc

  • Test tagging (slow/fast) currently done via go test -short flag. Go community doesn't seem to have a clear consensus to follow this pattern or to use env vars instead. Wrapped it in test/e2e/util/test to make changing it easier down the line if we decide to do so.

@kb-newrelic kb-newrelic requested a review from a team as a code owner December 16, 2024 18:37

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@kb-newrelic kb-newrelic force-pushed the kbauer/setup-nr-backend-tests branch from f97ea86 to a5ae1de Compare December 16, 2024 20:58
Copy link
Contributor

@mailo-nr mailo-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kb-newrelic kb-newrelic merged commit 6565923 into main Dec 16, 2024
6 checks passed
@kb-newrelic kb-newrelic deleted the kbauer/setup-nr-backend-tests branch December 16, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants