Fix unused variable warnings in unit tests #2552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaylareopelle
commented
Apr 11, 2024
Comment on lines
+279
to
281
| attribute_set_attempted = false | ||
| tl_current_mock = Minitest::Mock.new | ||
| tl_current_mock.expect :add_custom_attributes, -> { attribute_set_attempted = true }, [attrs] |
There was a problem hiding this comment.
The warning for this one said attribute_set_attempted was assigned, but never used, with the mock.expect line as the culprit. Defining the argument before the proc removed the warning.
kaylareopelle
requested review from
fallwith,
hannahramadan and
tannalynn
as code owners
fallwith
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was running some tests locally for #2546, I noticed we had a few "unused variable" warnings. This PR fixes those warnings.
Closes #2554