Configuration: support allowlists #2546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configuration hashes defined by `default_source.rb` now support an additional `:allowlist` key set equal to an array of valid values. If an invalid value is specified for a parameter that has an allowlist, a warning will be logged that contains the allowlist and the default value for the parameter will be used.
fallwith
requested review from
hannahramadan,
kaylareopelle and
tannalynn
as code owners
There was a problem hiding this comment.
Thank you, James! I like this idea. Like we talked about in standup today, it could have more applications, such as:
- Updating our documentation (config, newrelic.yml) to display allowlists so that we don't need to include them in the description text
- Revisiting the
instrumentation.*settings that permit onlyauto,prepend,chain,disabled
::NewRelic -> NewRelic
Remove the class specific config validation that is now redundant with the config's own allowlist validation
Now that the config handles the allowlist validation, remove the test expecting the 8T class to do so
SimpleCov Report
|
kaylareopelle
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configuration hashes defined by
default_source.rbnow support anadditional
:allowlistkey set equal to an array of valid values.If an invalid value is specified for a parameter that has an allowlist,
a warning will be logged that contains the allowlist and the default
value for the parameter will be used.
resolves #2555