-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop attributes with a value of None #1064
Conversation
3ff5b87
to
3f97674
Compare
🦙 MegaLinter status: ❌ ERROR
See detailed report in MegaLinter reports |
eaf843c
to
e104b53
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1064 +/- ##
=======================================
Coverage 76.36% 76.37%
=======================================
Files 190 190
Lines 19747 19748 +1
Branches 3468 3470 +2
=======================================
+ Hits 15080 15082 +2
Misses 3656 3656
+ Partials 1011 1010 -1 ☔ View full report in Codecov by Sentry. |
c3c9fed
to
e2b6c84
Compare
4039d06
to
bb818f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left comments, I've reviewed all the commits and it looks mostly good overall.
Now we can remove the check for None inside resolve_user_attributes since process_user_attribute is always called on the attributes before they are passed to resolve_user_attributes. This None check is unreachable code and not needed.
create_user_attributes is a passthrough to create_attributes. Just remove this function, there's no need for it.
18c0011
to
5bbf0dc
Compare
Overview
This PR attempts to align the Python agent with the agent spec by dropping attributes with a value of None.
According to the spec:
It also performs some minor cleanup and adds descriptions to some function inside our attribute filtering system.
It also contains a fix for previously failing sklearn tests due to a non integer version:
0.0.post12
.Recommended review strategy: review each commit one at a time.