Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(integration-tests): Resolve newrelic-client-go failed integration tests #1264

Merged
merged 3 commits into from
Jan 29, 2025
Merged

fix(integration-tests): Resolve newrelic-client-go failed integration tests #1264

merged 3 commits into from
Jan 29, 2025
+65 −3

Conversation

Aashirwadjain
Copy link
Collaborator

@Aashirwadjain Aashirwadjain commented Jan 23, 2025 •
edited
Loading

Description

  • This pull request addresses several issues in integration tests identified in the integration tests of newrelic-client-go repository.
  • The following test cases have been updated:
    • TestSyntheticsStepMonitor_GetSteps
    • TestSyntheticsBrokenLinksMonitor_Basic
    • TestSyntheticsScriptApiMonitorLegacy_Basic
    • TestIntegrationCreateWorkflow

Changes Made

  • Added appropriate runtimeType and runtimeTypeVersion to the synthetics test cases.
  • Updated the expectedUpdateOriginalMessage attribute in TestIntegrationCreateWorkflow.

@Aashirwadjain
fix(runtime-integration-tests): add runtime attribute to synthetics t…
Loading
Loading status checks…
72472da 
…ests
@Aashirwadjain
fix(workflow-integration-tests): fix expectedUpdateOriginalMessage at…
Loading
Loading status checks…
2fe3986 
…tribute in TestIntegrationCreateWorkflow
@Aashirwadjain Aashirwadjain changed the title fix(integration-tests): Resolve newrelic-client-go integration tests fix(integration-tests): Resolve newrelic-client-go failed integration tests Jan 23, 2025
@Aashirwadjain
fix(synthetics-integration-tests): add TestSyntheticsStepMonitor_Fail…
Loading
Loading status checks…
e8ce9bc 
… test case for runtime error validation
@Aashirwadjain Aashirwadjain merged commit 1267425 into main Jan 29, 2025
11 of 12 checks passed
@Aashirwadjain Aashirwadjain deleted the fix-integration-tests branch January 29, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinay-newrelic vinay-newrelic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Aashirwadjain @vinay-newrelic