Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor or replace macm_workflow with MACMWorkflow class #850

Open
JulioAPeraza opened this issue Dec 11, 2023 · 0 comments
Open

Refactor or replace macm_workflow with MACMWorkflow class #850

JulioAPeraza opened this issue Dec 11, 2023 · 0 comments
Labels
deprecation Classes/functions/behaviors flagged for later removal. enhancement New feature or request question Further information is requested refactoring Requesting changes to the code which do not impact behavior workflows Issues related to the workflows module

Comments

@JulioAPeraza
Copy link
Collaborator

I was thinking of refactoring the macm_workflow with CBMAWorkflow and PairwiseCBMAWorkflow.
Another alternative would be creating a new class MACMWorkflow that is fitted to a dataset and mask and uses CBMAWorkflow and PairwiseCBMAWorkflow to perform the meta-analysis correction and diagnostic depending on the estimator.

@tsalo @jdkent WDYT?
@JulioAPeraza JulioAPeraza added enhancement New feature or request question Further information is requested refactoring Requesting changes to the code which do not impact behavior workflows Issues related to the workflows module deprecation Classes/functions/behaviors flagged for later removal. labels Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
deprecation Classes/functions/behaviors flagged for later removal. enhancement New feature or request question Further information is requested refactoring Requesting changes to the code which do not impact behavior workflows Issues related to the workflows module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JulioAPeraza