Discuss test assertions

[rmanaem]

Asserting over what is returned from the mocked get function in test_query has been brought up multiple times during conversations and PRs, most recently here.
I'd like us to think about the questions below:

• Is what we have unnecessary? since it's simply being fed into the test and asserted on
  If not
• Is what we currently have (simply check if the returned list is empty or not) enough?
  If not
• Do we want to check each of the properties in the AggDatasetResponse?

Or perhaps we need to re-think and re-work the implementation.

Other thoughts related to testing:

Because we are mocking our get method in our tests (good), and the query generator is called only inside the get method - technically inside the httpx.post call (neutral), the query generator is never tested (bad).

One answer is to make separate unit tests for the query generator.

What do you think?

[surchs]

Related to #48

[github-actions]

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 30 days.
We have applied the stale-issue label to indicate that this issue should be reviewed again and then either prioritized or closed.