Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] Switched to lifespan events #287

Closed
wants to merge 8 commits into from

Conversation

samadpls
Copy link
Contributor

Changes proposed in this pull request:

  • Replace startup and shutdown events with lifespan events

Checklist

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

Signed-off-by: samadpls <abdulsamadsid1@gmail.com>
Signed-off-by: samadpls <abdulsamadsid1@gmail.com>
Signed-off-by: samadpls <abdulsamadsid1@gmail.com>
@coveralls
Copy link
Collaborator

coveralls commented Mar 13, 2024

Pull Request Test Coverage Report for Build 8746974931

Details

  • 15 of 15 (100.0%) changed or added relevant lines in 1 file are covered.
  • 25 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-4.1%) to 95.707%

Files with Coverage Reduction New Missed Lines %
app/main.py 3 91.3%
app/api/crud.py 6 90.0%
app/api/utility.py 16 85.84%
Totals Coverage Status
Change from base Build 8712149137: -4.1%
Covered Lines: 602
Relevant Lines: 629

💛 - Coveralls

@alyssadai alyssadai added the _community [BOT ONLY] PR label for community contributions. Used for tracking label Apr 2, 2024
@samadpls
Copy link
Contributor Author

samadpls commented Apr 5, 2024

@alyssadai , could you please review it whenever its convenient for you…

@alyssadai
Copy link
Contributor

Hey @samadpls, thanks a lot for your PR, and sorry for the very long delay in review. The dev team has been unusually swamped over the past while given some urgent internal project tasks.

One of the maintainers get back to you as soon as we can. Thanks so much for your patience!

@samadpls samadpls marked this pull request as draft April 19, 2024 01:20
@samadpls
Copy link
Contributor Author

samadpls commented May 9, 2024

Closing this PR due to its inactive status. I'd love to continue working on it if it receives reviews in the future. Thank you for the opportunity😊

@samadpls samadpls closed this May 9, 2024
@surchs
Copy link
Contributor

surchs commented May 9, 2024

@samadpls hey, that's fair - sorry this didn't work out as quickly as we would have liked here. We aim to have reviews come in quicker normally, but I think your PR slipped through the cracks because it was a busy time with many priorities.

Please do stay in touch and feel very welcome to contribute again on our repos! We'll make sure to stay on top of this in the future (we now have a "Community" section in our project board to help with that).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
_community [BOT ONLY] PR label for community contributions. Used for tracking
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Switch deprecated startup events to lifespan events
4 participants