Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write a test that default values of env vars are correctly applied #127

Open
alyssadai opened this issue May 26, 2023 · 1 comment
Open

Write a test that default values of env vars are correctly applied #127

alyssadai opened this issue May 26, 2023 · 1 comment
Labels
maint:coverage Test coverage improvements that were not included in feature prioritization someday Not a priority right now, but we want to keep this around to think or discuss more. type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs

Comments

@alyssadai
Copy link
Contributor

alyssadai commented May 26, 2023 •
edited

In the past we've encountered some issues with the default values of environment variables not being applied (or being applied with the wrong values) when launching the API+graph stack, mainly when using docker compose.

A nice-to-have sanity check at some point would be a test that verifies the default values when the API is launched with Python vs. docker compose, although since the values vary slightly depending on the deployment method this likely will first involve some research into how to re-create the compose environment using pytest / actions.
@alyssadai alyssadai added type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs maint:coverage Test coverage improvements that were not included in feature prioritization labels May 26, 2023
@github-actions
Copy link

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 30 days.
We have applied the stale-issue label to indicate that this issue should be reviewed again and then either prioritized or closed.

@github-actions github-actions bot added the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Aug 17, 2023
@surchs surchs added flag:detail needed Issue requires additional clarification before a decision can be made or it can be implemented. flag:schedule Flag issue that should go on the roadmap or backlog. and removed flag:detail needed Issue requires additional clarification before a decision can be made or it can be implemented. _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again labels Oct 17, 2023
@alyssadai alyssadai added someday Not a priority right now, but we want to keep this around to think or discuss more. and removed flag:schedule Flag issue that should go on the roadmap or backlog. flag:detail needed Issue requires additional clarification before a decision can be made or it can be implemented. labels Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maint:coverage Test coverage improvements that were not included in feature prioritization someday Not a priority right now, but we want to keep this around to think or discuss more. type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs
Projects
Neurobagel
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@surchs @alyssadai