Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow modifier loggers to be overwritten by subsequent initialize_loggers calls #896

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

KSGulin
Copy link
Contributor

@KSGulin KSGulin commented Jun 21, 2022

In some integrations (currently only YOLOv5), the loggers are set after the initial manager initialize. Current behavior prevents overwriting modifier loggers, thus the loggers for the integration always get set to the default. This protection is no longer needed and has been removed here.

Also hardened the step setting logic for modifier logging, allowed epoch values of 0 to get registered.

@KSGulin KSGulin requested review from a team, abf149, eldarkurtic and InquestGeronimo and removed request for a team June 21, 2022 14:37
@KSGulin KSGulin self-assigned this Jun 21, 2022
@KSGulin KSGulin merged commit 9a197aa into main Jun 21, 2022
@KSGulin KSGulin deleted the allow-loggers-overwrite branch June 21, 2022 14:46
bfineran added a commit that referenced this pull request Jun 21, 2022
…899)

Co-authored-by: Konstantin Gulin <66528950+KSGulin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants