Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing of complex Symbols is slow #152

Open
skleber opened this issue Oct 18, 2018 · 0 comments
Open

Parsing of complex Symbols is slow #152

skleber opened this issue Oct 18, 2018 · 0 comments

Comments

@skleber
Copy link
Contributor

skleber commented Oct 18, 2018

Parsing of messages according to complex symbol definitions takes ridiculous amounts of time (on an i7 machine, way over 24 hours for a 1000 messages DHCP trace).

Proposed Solution:

Introduce caching of intermediate partial parsing paths that take a long time to compute and are needed multiple times during message parsing (according to the debug output the same byte values for getDataAssignedToField get parsed with the same field definition several times).

I have tried to implement something like that but failed due to my missing understanding of how exactly the the ParsingPath is walked during the calls to MessageParser._parseBitArrayWithField().

Do you have any comment on my approach or even better: could you help me by some additional information about what's going during MessageParsing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant