Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Length infered for dynamic length fields sometimes is wrong #133

Open
skleber opened this issue Nov 4, 2017 · 0 comments
Open

Length infered for dynamic length fields sometimes is wrong #133

skleber opened this issue Nov 4, 2017 · 0 comments

Comments

@skleber
Copy link
Contributor

skleber commented Nov 4, 2017

The maximum field length infered for dynamic fields by
netzob.Inference.Vocabulary.FormatOperations.FieldSplitAligned.FieldSplitAligned.FieldSplitAligned#_mergeAlign
into the tuple (entryVal, entryDyn) from variable splited in line 252 of
FieldSplitAligned.py
is not correct for "some" inferences like:

<class 'ScapyDissector_ntp.NTPi_Symbol2'>
fieldlengths netzob from domain
[8, 8, 8, 16, 8, 24, 8, 8, 16, 224, 80]
408
fieldlengths netzob counted in value
[8, 8, 8, 16, 8, 24, 0, 8, 16, 224, 64]
384

The values at the bottom are correct, i. e. 64 instead of 80.

I will provide some minimum working example to verify in the near future.

@skleber skleber mentioned this issue Nov 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant