Use PlatformDependent.threadLocalRandom() to reduce memory footprint
#13977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchrys
changed the title
PlatformDependent.threadLocalRandom()PlatformDependent.threadLocalRandom() to reduce memory footprint
Motivation: Direct use of `io.netty.util.internal.ThreadLocalRandom` and `j.u.c.ThreadLocalRandom` could cause a lot of memory waste. Modifications: Use `PlatformDependent.threadLocalRandom()`. Result: Reduced Memory footprint.
jchrys
force-pushed
the
4.1-threadlocal-memory
branch
from
ca27258
to
c542df0
Compare
chrisvest
approved these changes
Apr 15, 2024
shoothzj
approved these changes
Apr 15, 2024
I thought this patch would affect java >= 7, Since it used |
|
@jchrys thanks |
You're correct. I misread it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Direct use of
io.netty.util.internal.ThreadLocalRandomandj.u.c.ThreadLocalRandomcould cause a lot of memory waste.Modifications:
Use
PlatformDependent.threadLocalRandom().Result:
Reduced Memory footprint.