Utilize ByteBuf#indexOf
#13974
Merged
Utilize ByteBuf#indexOf
#13974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently, in Netty5 and 4.1, we provide public |
jchrys
force-pushed
the
4.1-discourage-indexOfrocessor
branch
from
7762b1a
to
a2b4fb4
Compare
Motivation: `ByteBuf#indexOf` employees advanced algorithm to search a given byte. Modification: Utilize `ByteBuf#indexOf` instead `forEachByte`. Result: Better performance.
jchrys
force-pushed
the
4.1-discourage-indexOfrocessor
branch
from
a2b4fb4
to
0a05033
Compare
chrisvest
approved these changes
Apr 13, 2024
|
@jchrys please port to main as well and open a PR |
|
Sure! Let me check :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
ByteBuf#indexOfemployees advanced algorithm to search a given byte.Modification:
Utilize
ByteBuf#indexOfinsteadforEachByte.Result:
Better performance.