Refactor file descriptor handling in openFileDescriptors() #13955
+13
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisvest
reviewed
Apr 6, 2024
There was a problem hiding this comment.
Did you sign the ICLA? https://netty.io/wiki/developer-guide.html
| // ignore | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Add a line break between this and the next method.
There was a problem hiding this comment.
ok，I made it up in the second commit
There was a problem hiding this comment.
Also between this one and newTaskQueue below.
There was a problem hiding this comment.
sorry，my carelessness
Yes, I have completed the ICLA process. |
|
Looks like you messed up the rebase and entangled your changes with the merge of #13942. Please fix. |
Fixed. |
chrisvest
approved these changes
Apr 9, 2024
|
Thanks! |
chrisvest
pushed a commit
that referenced
this pull request
Apr 10, 2024
Motivation: The motivation behind this change is to enhance the readability and maintainability of the codebase by refactoring the file descriptor handling in the openFileDescriptors method. By extracting the logic for closing file descriptors into a separate method, closeFileDescriptor, Modification: In this commit, I have refactored the openFileDescriptors method by extracting the code responsible for closing file descriptors into a separate method, closeFileDescriptor. Result: This PR introduces improved code organization and readability by separating the concerns of opening and closing file descriptors in the openFileDescriptors method. It does not introduce any functional changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The motivation behind this change is to enhance the readability and maintainability of the codebase by refactoring the file descriptor handling in the openFileDescriptors method. By extracting the logic for closing file descriptors into a separate method, closeFileDescriptor,
Modification:
In this commit, I have refactored the openFileDescriptors method by extracting the code responsible for closing file descriptors into a separate method, closeFileDescriptor.
Result:
This PR introduces improved code organization and readability by separating the concerns of opening and closing file descriptors in the openFileDescriptors method. It does not introduce any functional changes.