Change the default value of maxMessagePerRead to 16 in ChannelMetadata #13680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We used 1 as the default value for maxMessagesPerRead in ChannelMetadata which is a very bad default for performance reasons. Because of this we usually explicit use 16 when constructing it. To eliminate problems when we forgot to do so let's use 16 as default. Modifications: Change default to 16 Result: Better performance by default
violetagg
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We used 1 as the default value for maxMessagesPerRead in ChannelMetadata which is a very bad default for performance reasons. Because of this we usually explicit use 16 when constructing it. To eliminate problems when we forgot to do so let's use 16 as default.
Modifications:
Change default to 16
Result:
Better performance by default