Change default value of MAX_MESSAGES_PER_READ for DatagramChannel imp… #13676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lementations Motivation: All our DatagramChannel implementations used a MAX_MESSAGES_PER_READ of 1 due the fact of how they used the ChannelMetaData constructor. This makes no sense and hurts performance a lot as it will basically result in have fireChannelRead(...) only called once and then direct fireChannelReadComplete(...). For example in a QUIC benchmark I did observe receiving a 1 GB file did take 14 seconds. After chaning the default to 16 (which is also what other Channels use) this dropped to 6 seconds for the specific benchmark. Modifications: Use a default of 16 messages per read when using DatagramChannels Result: Better performance with default settings
|
This was discovered here netty/netty-incubator-codec-quic#598 |
chrisvest
approved these changes
Nov 1, 2023
Scottmitch
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lementations
Motivation:
All our DatagramChannel implementations used a MAX_MESSAGES_PER_READ of 1 due the fact of how they used the ChannelMetaData constructor. This makes no sense and hurts performance a lot as it will basically result in have fireChannelRead(...) only called once and then direct fireChannelReadComplete(...).
For example in a QUIC benchmark I did observe receiving a 1 GB file did take 14 seconds. After chaning the default to 16 (which is also what other Channels use) this dropped to 6 seconds for the specific benchmark.
Modifications:
Use a default of 16 messages per read when using DatagramChannels
Result:
Better performance with default settings