Add a specific test for optional whitespace in HTTP headers #13486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This proves that we handle optional whitespace correctly when we decode HTTP headers.
normanmaurer
approved these changes
Jul 13, 2023
normanmaurer
requested changes
Jul 13, 2023
codec-http/src/test/java/io/netty/handler/codec/http/HttpRequestDecoderTest.java
Show resolved
Hide resolved
Co-authored-by: Norman Maurer <norman_maurer@apple.com>
normanmaurer
requested changes
Jul 14, 2023
codec-http/src/test/java/io/netty/handler/codec/http/HttpRequestDecoderTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Norman Maurer <norman_maurer@apple.com>
|
@chrisvest can you port to main as well ? |
chrisvest
added a commit
that referenced
this pull request
Jul 17, 2023
Motivation: Since we made header value validation more strict in 4.1.84, we've gotten the occasional issue reported that whitespace isn't handled correctly. Modification: Add a test that stresses the optional whitespace decoding of HTTP headers, because I think we didn't have one already. Also include a javadoc comment with relevant RFC references. Result: This proves that we handle optional whitespace correctly when we decode HTTP headers. --------- Co-authored-by: Norman Maurer <norman_maurer@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Since we made header value validation more strict in 4.1.84, we've gotten the occasional issue reported that whitespace isn't handled correctly.
Modification:
Add a test that stresses the optional whitespace decoding of HTTP headers, because I think we didn't have one already.
Also include a javadoc comment with relevant RFC references.
Result:
This proves that we handle optional whitespace correctly when we decode HTTP headers.