Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WriteTask can use unguarded release? #13356

Open
franz1981 opened this issue Apr 22, 2023 · 3 comments
Open

WriteTask can use unguarded release? #13356

franz1981 opened this issue Apr 22, 2023 · 3 comments
Assignees
@franz1981
Labels
discussion

Comments

@franz1981
Copy link
Contributor

franz1981 commented Apr 22, 2023 •
edited

#13153 improved buffer releases, but WriteTask was left out, see

        at app//io.netty.util.Recycler$LocalPool.release(Recycler.java:344)
	at app//io.netty.util.Recycler$DefaultHandle.recycle(Recycler.java:257)
	at app//io.netty.channel.AbstractChannelHandlerContext$WriteTask.recycle(AbstractChannelHandlerContext.java:1273)
	at app//io.netty.channel.AbstractChannelHandlerContext$WriteTask.run(AbstractChannelHandlerContext.java:1250)

@normanmaurer @chrisvest wdyt?
@franz1981 franz1981 self-assigned this Apr 22, 2023
@normanmaurer
Copy link
Member

@franz1981 sounds ok to me... @chrisvest thoughts ?

@chrisvest
Copy link
Contributor

@franz1981 @normanmaurer I don't see a problem with doing that.

@normanmaurer
Copy link
Member

@franz1981 its still on your radar ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@franz1981 franz1981

Labels
discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chrisvest @normanmaurer @franz1981