Deprecates LazyRunnable #13336
Merged
Deprecates LazyRunnable #13336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Type check vs LazyRunnable receive an always-on performance hit for a common operation that users shouldn't pay if they won't use it. Modifications: Deprecates LazyRunnable providing a comment to help existing users an alternative mechanism. Result: Fixes netty#13335
He-Pin
reviewed
Apr 17, 2023
common/src/main/java/io/netty/util/concurrent/AbstractEventExecutor.java
Show resolved
Hide resolved
chrisvest
approved these changes
Apr 17, 2023
common/src/main/java/io/netty/util/concurrent/SingleThreadEventExecutor.java
Outdated
Show resolved
Hide resolved
common/src/main/java/io/netty/util/concurrent/AbstractEventExecutor.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Chris Vest <mr.chrisvest@gmail.com>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Type check vs LazyRunnable receive an always-on performance hit for a common operation that users shouldn't pay if they won't use it.
Modifications:
Deprecates LazyRunnable providing a comment to help existing users an alternative mechanism.
Result:
Fixes #13335