Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle EHOSTUNREACH errors in io.netty.channel.unix.Errors (#13317) #13318

Merged
merged 1 commit into from Apr 3, 2023
Merged

Handle EHOSTUNREACH errors in io.netty.channel.unix.Errors (#13317) #13318

merged 1 commit into from Apr 3, 2023

Conversation

tristantarrant
Copy link
Contributor

Fixes #13317

@tristantarrant
Handle EHOSTUNREACH errors in io.netty.channel.unix.Errors (netty#13317)
88a81a0 
    Motivation:

    We should throw a NoRouteToHostException when a socket connection fails with EHOSTUNREACH in the same way as
    ENETUNREACH.

    Modifications:

    Add handling for EHOSTUNREACH

    Result:

    Correct exception is thrown.
@franz1981
Copy link
Contributor

Good catch @tristantarrant did you already signed our license agreement?
Last point of https://netty.io/wiki/developer-guide.html#checklist

@tristantarrant
Copy link
Contributor Author

Yep, I have signed the CLA

@normanmaurer normanmaurer merged commit 76d83fe into netty:4.1 Apr 3, 2023
8 of 15 checks passed
@normanmaurer normanmaurer added this to the 4.1.91.Final milestone Apr 3, 2023
normanmaurer pushed a commit that referenced this pull request Apr 3, 2023
@tristantarrant @normanmaurer
Handle EHOSTUNREACH errors in io.netty.channel.unix.Errors (#13317) (#…
20f4c07 
…13318)

Motivation:

    We should throw a NoRouteToHostException when a socket connection fails with EHOSTUNREACH in the same way as
    ENETUNREACH.

    Modifications:

    Add handling for EHOSTUNREACH

    Result:

    Correct exception is thrown.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@normanmaurer normanmaurer normanmaurer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1.91.Final
3 participants
@tristantarrant @franz1981 @normanmaurer