Update: Add snappy support on HttpContentDecoder #13312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: I want to allow logstash http input to be able to read snappy compressed data. Modifications: To allow the HttpContentDecoder to support snappy it created a new control flow to test for snappy content encoding. If it is present, we are using a specific snappy decompressor to read the data. In order to make sure it was working I also included a e2e test on the behaior of HttpContentDecoder. Result: We should be able to send snappy traffic to a server using HttpContentDocder and be ale to uncompresse the traffic.
hyperxpro
suggested changes
Apr 2, 2023
codec-http/src/main/java/io/netty/handler/codec/http/HttpContentDecompressor.java
Outdated
Show resolved
Hide resolved
codec-http/src/main/java/io/netty/handler/codec/http/HttpHeaderValues.java
Outdated
Show resolved
Hide resolved
codec-http/src/test/java/io/netty/handler/codec/http/HttpContentDecoderTest.java
Outdated
Show resolved
Hide resolved
codec-http/src/test/java/io/netty/handler/codec/http/HttpContentDecoderTest.java
Show resolved
Hide resolved
codec-http/src/test/java/io/netty/handler/codec/http/HttpContentDecoderTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Aayush Atharva <hyperx.pro@outlook.com>
normanmaurer
reviewed
Apr 2, 2023
codec-http/src/main/java/io/netty/handler/codec/http/HttpContentDecompressor.java
Outdated
Show resolved
Hide resolved
…ntDecompressor.java
|
@redcinelli can you please sign our ICLA: https://netty.io/s/icla ? |
|
We also need this for Http2. |
Hi @normanmaurer, I believe I had done it already. I have re-done it anyway just to make sure. 👌 |
normanmaurer
added a commit
that referenced
this pull request
Apr 3, 2023
Motivation: I want to allow logstash http input to be able to read snappy compressed data. Modifications: To allow the HttpContentDecoder to support snappy it created a new control flow to test for snappy content encoding. If it is present, we are using a specific snappy decompressor to read the data. In order to make sure it was working I also included a e2e test on the behaior of HttpContentDecoder. Result: We should be able to send snappy traffic to a server using HttpContentDocder and be ale to uncompresse the traffic. Co-authored-by: Aayush Atharva <hyperx.pro@outlook.com> Co-authored-by: Norman Maurer <norman_maurer@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
I want to allow logstash http input to be able to read snappy compressed data.
Modifications:
To allow the HttpContentDecoder to support snappy it created a new control flow to test for snappy content encoding.
If it is present, we are using a specific snappy decompressor to read the data.
In order to make sure it was working I also included a e2e test on the behaviour of HttpContentDecoder.
Result:
We should be able to send snappy traffic to a server using HttpContentDocder and be ale to uncompress the traffic.
Fixes #13307