Use the correct error when reset a stream #13309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: At the moment we always used "CANCEL" when reseting a stream because of an error. This is not correct, we should use the error that caused the stream error. Modifications: - Use correct error when reset a stream. - Add unit test Result: Correctly propagate stream errors via reset
normanmaurer
requested review from
bryce-anderson,
chrisvest and
idelpivnitskiy
|
/cc @violetagg |
violetagg
approved these changes
Mar 30, 2023
chrisvest
approved these changes
Mar 30, 2023
idelpivnitskiy
approved these changes
Mar 30, 2023
bryce-anderson
approved these changes
Mar 30, 2023
normanmaurer
added a commit
that referenced
this pull request
Mar 31, 2023
Motivation: At the moment we always used "CANCEL" when reseting a stream because of an error. This is not correct, we should use the error that caused the stream error. Modifications: - Use correct error when reset a stream. - Add unit test Result: Correctly propagate stream errors via reset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
At the moment we always used "CANCEL" when reseting a stream because of an error. This is not correct, we should use the error that caused the stream error.
Modifications:
Result:
Correctly propagate stream errors via reset