Don't reset BCSSLParameters when setting application protocols #13262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We had a bug that lead to resetting the BCSSLParameters during setting the applications protocols. Modifications: Retrieve already configured BCSSLParameters and use these to set the application protocol Result: Fixes #13261
|
@rajeshpnair can you verify this one ? |
@normanmaurer this is not sufficient to fix #13261 , the SSLParameters of SSLEngine need to be set with application protocols , its currently getting reset . Please see the pr #13263 |
|
@rajeshpnair PTAL again... I think now it's more correct. |
|
@normanmaurer , thanks its correct now. |
normanmaurer
added a commit
that referenced
this pull request
Mar 9, 2023
Motivation: We had a bug that lead to resetting the BCSSLParameters during setting the applications protocols. Modifications: Retrieve already configured BCSSLParameters and use these to set the application protocol Result: Fixes #13261
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We had a bug that lead to resetting the BCSSLParameters during setting the applications protocols.
Modifications:
Retrieve already configured BCSSLParameters and use these to set the application protocol
Result:
Fixes #13261