Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native image: add support for unix domain sockets #13242

Merged
merged 1 commit into from Mar 2, 2023

Conversation

mostroverkhov
Copy link
Contributor

Motivation:

unix domain sockets with graalvm native image require additional reflection configuration.

Modification:

add unix domain sockets graalvm configuration in reflect-config.json.

Result:

unix domain sockets with graalvm native image work out of the box.

Motivation:

unix domain sockets with graalvm native image require additional reflection configuration

Modification:

add unix domain sockets graalvm configuration in reflect-config.json

Result:

unix domain sockets with graalvm native image work out of the box
@chrisvest
Copy link
Contributor

The ni_metadata.sh should be capturing what we need and generate those files, AFAIU. Maybe the tests we run have a blind spot for unix domain sockets?

CC @gradinac

@gradinac
Copy link
Contributor

gradinac commented Mar 2, 2023

The ni_metadata.sh script is only used for Netty 5 IIRC well. I think we used it to collect the initial Netty 4 metadata that we provide in the reachability metadata repository, however this entry does seem to be missing even there. My guess is that the metadata for the epoll suite got wrongly filtered by the agent as I could find the following reference to for example io.netty.channel.epoll.EpollDomainSocketChannel in the following test: https://github.com/netty/netty/blob/4.1/transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollSocketTestPermutation.java#L229. I assume there may be more, this is just one where we're most likely to have need for reflective metadata

@normanmaurer
Copy link
Member

@gradinac so correct me if I am wrong but you suggest we should just pull this in ?

@gradinac
Copy link
Contributor

gradinac commented Mar 2, 2023

@normanmaurer I think it may be worthwhile pulling this in, especially because the handcrafted metadata conditions here seem correct (only even pull this in if Native from epoll is reachable)

@normanmaurer normanmaurer merged commit 84cf7d6 into netty:4.1 Mar 2, 2023
@normanmaurer normanmaurer added this to the 4.1.90.Final milestone Mar 2, 2023
@normanmaurer
Copy link
Member

Thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants