-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: adds context for docs #398
Conversation
Added mentions of Essential Next.js plugin for users coming to these docs pages from links outside this repo.
@@ -1,6 +1,7 @@ | |||
## Custom Netlify Redirects | |||
|
|||
You can define custom redirects in a `_redirects` file. | |||
You can define custom redirects in a `_redirects` file for apps using the Essential Next.js plugin. | |||
|
|||
The precedence of these rules are: | |||
|
|||
- `_redirects` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checking on the line below whether this should still read "next-on-netlify
redirects" or whether it needs to be updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oooo yes you could update the line below to " Essential Next.js
redirects " 💡
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this!!!!!!!!!!!!!!!
@@ -1,6 +1,7 @@ | |||
## Custom Netlify Redirects | |||
|
|||
You can define custom redirects in a `_redirects` file. | |||
You can define custom redirects in a `_redirects` file for apps using the Essential Next.js plugin. | |||
|
|||
The precedence of these rules are: | |||
|
|||
- `_redirects` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oooo yes you could update the line below to " Essential Next.js
redirects " 💡
commit name needs to be appended with either chore fix or feat so |
* chore: Add buildVersion and useRegionalBlobs to PluginContext * chore: Centralize deploy store configuration * chore: Extract FixtureTestContext and BLOB_TOKEN into their own files * chore: Prepare getBlobServerGets to handle regions * chore: Set and make use of shared build/run USE_REGIONAL_BLOBS environment variable * chore: Use latest @netlify/blobs version * chore: Pin regional blob functionality to a higher version of the cli * chore: mark all runtime modules as external * fix: Ensure ts files are compiled in unit tests * chore: linting * maybe win slash? * test: add fixture using CLI before regional blobs support * test: use createRequestContext in tests instead of manually creating request context objects * Update tests/e2e/page-router.test.ts Co-authored-by: Philippe Serhal <philippe.serhal@gmail.com> * test: rename unit test for blobs directory --------- Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com> Co-authored-by: Philippe Serhal <philippe.serhal@gmail.com>
Added mentions of Essential Next.js plugin for users coming to these docs pages from links outside this repo.
Created this PR in tandem with an open Netlify docs PR. (https://github.com/netlify/docs/pull/1235)