Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adds context for docs #398

Merged
merged 2 commits into from
Jun 8, 2021
Merged

docs: adds context for docs #398

merged 2 commits into from
Jun 8, 2021

Conversation

rstavchansky
Copy link

Added mentions of Essential Next.js plugin for users coming to these docs pages from links outside this repo.
Created this PR in tandem with an open Netlify docs PR. (https://github.com/netlify/docs/pull/1235)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Added mentions of Essential Next.js plugin for users coming to these docs pages from links outside this repo.
@rstavchansky rstavchansky added documentation Improvements or additions to documentation type: chore work needed to keep the product and development running smoothly labels Jun 8, 2021
@@ -1,6 +1,7 @@
## Custom Netlify Redirects

You can define custom redirects in a `_redirects` file.
You can define custom redirects in a `_redirects` file for apps using the Essential Next.js plugin.

The precedence of these rules are:

- `_redirects`
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking on the line below whether this should still read "next-on-netlify redirects" or whether it needs to be updated.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oooo yes you could update the line below to " Essential Next.js redirects " 💡

Copy link

@lindsaylevine lindsaylevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this!!!!!!!!!!!!!!!

@@ -1,6 +1,7 @@
## Custom Netlify Redirects

You can define custom redirects in a `_redirects` file.
You can define custom redirects in a `_redirects` file for apps using the Essential Next.js plugin.

The precedence of these rules are:

- `_redirects`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oooo yes you could update the line below to " Essential Next.js redirects " 💡

@lindsaylevine
Copy link

commit name needs to be appended with either chore fix or feat so chore: adds context for docs. lmk if u need help updating/rebasing :D

@ascorbic ascorbic changed the title Adds context for docs docs: adds context for docs Jun 8, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@rstavchansky rstavchansky merged commit 296a7f1 into main Jun 8, 2021
@rstavchansky rstavchansky deleted the chore/docs-clarifications branch June 8, 2021 16:33
serhalp added a commit that referenced this pull request Jun 13, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* chore: Add buildVersion and useRegionalBlobs to PluginContext

* chore: Centralize deploy store configuration

* chore: Extract FixtureTestContext and BLOB_TOKEN into their own files

* chore: Prepare getBlobServerGets to handle regions

* chore: Set and make use of shared build/run USE_REGIONAL_BLOBS environment variable

* chore: Use latest @netlify/blobs version

* chore: Pin regional blob functionality to a higher version of the cli

* chore: mark all runtime modules as external

* fix: Ensure ts files are compiled in unit tests

* chore: linting

* maybe win slash?

* test: add fixture using CLI before regional blobs support

* test: use createRequestContext in tests instead of manually creating request context objects

* Update tests/e2e/page-router.test.ts

Co-authored-by: Philippe Serhal <philippe.serhal@gmail.com>

* test: rename unit test for blobs directory

---------

Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
Co-authored-by: Philippe Serhal <philippe.serhal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants