Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate netlify-plugin-cache-nextjs? #391

Closed
jonahsnider opened this issue Jun 7, 2021 · 5 comments
Closed

Deprecate netlify-plugin-cache-nextjs? #391

jonahsnider opened this issue Jun 7, 2021 · 5 comments

Comments

@jonahsnider
Copy link

I noticed that #185 introduced caching functionality that works as a replacement to my Next.js cache plugin.

Should I deprecate that plugin in favor of this one?

(also: consider updating this blog post to remove references to my plugin)

@lindsaylevine
Copy link

@jonahsnider hey jonah, thanks for noticing and opening this with us! cc @jlengstorf on the blog post but yes, you can deprecate your plugin! you don't need to, but as you saw, we wanted to offer what your plugin so generously offered automatically for all next.js sites :)

@jonahsnider
Copy link
Author

I think the current cache functionality is slightly lacking compared to my plugin (ex. output on success/error), so I'll wait a few months and then mark my package as deprecated.

@lindsaylevine
Copy link

@jonahsnider what exactly is lacking? we reviewed your src before adding caching here. pls don't hesitate to open a PR to us for whatever you feel is missing.

@jonahsnider
Copy link
Author

jonahsnider commented Jun 8, 2021

It's not a very important feature but my plugin uses rich status information in the deploy summary for success.
More valuable would be using a warning (once that gets added) on errors.

deploy summary

@ascorbic
Copy link
Contributor

ascorbic commented Jun 9, 2021

This is fixed in #400

serhalp pushed a commit that referenced this issue Apr 5, 2024
#391)

* test: add integration test for cacheable route handler response not produced at build

* fix: don't mutate route data, instead create new object to set as blob
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants