-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate netlify-plugin-cache-nextjs
?
#391
Comments
@jonahsnider hey jonah, thanks for noticing and opening this with us! cc @jlengstorf on the blog post but yes, you can deprecate your plugin! you don't need to, but as you saw, we wanted to offer what your plugin so generously offered automatically for all next.js sites :) |
I think the current cache functionality is slightly lacking compared to my plugin (ex. output on success/error), so I'll wait a few months and then mark my package as deprecated. |
@jonahsnider what exactly is lacking? we reviewed your src before adding caching here. pls don't hesitate to open a PR to us for whatever you feel is missing. |
It's not a very important feature but my plugin uses rich status information in the deploy summary for success. |
This is fixed in #400 |
#391) * test: add integration test for cacheable route handler response not produced at build * fix: don't mutate route data, instead create new object to set as blob
I noticed that #185 introduced caching functionality that works as a replacement to my Next.js cache plugin.
Should I deprecate that plugin in favor of this one?
(also: consider updating this blog post to remove references to my plugin)
The text was updated successfully, but these errors were encountered: