Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backport update failure points in plugin to do nothing instead to v1 #146

Merged
merged 2 commits into from
Mar 16, 2021

Conversation

erezrokah
Copy link

@erezrokah erezrokah commented Mar 16, 2021

Fixes #144

I created 2 branches out of the v1.1.1 tag:

  1. release_v1.1.1 to represent the release.
  2. fix/backport_no_op to represent the fix.

This PR cherry picks b2718f2 and wants to merge it from fix/backport_no_op to release_v1.1.1 so we can cut a release from that branch.

I also kept the experimental version as 10.0.0 (see 723be5d)

I tested this locally and it works (I used https://github.com/erezrokah/next-starter-jamstack which is the starter with the update to Next.js 10 reverted)

lindsaylevine and others added 2 commits March 16, 2021 16:53

Verified

This commit was signed with the committer’s verified signature.
wmouchere William Mouchère
* update failure points in plugin to do nothing instead

* refactor passing nextConfigPath into doesNotNeedPlugin

Verified

This commit was signed with the committer’s verified signature.
wmouchere William Mouchère
Copy link

@jlengstorf jlengstorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks correct to me. let's roll it out! thank you!

@erezrokah erezrokah merged commit 9a32ace into release_v1.1.1 Mar 16, 2021
@erezrokah erezrokah deleted the fix/backport_no_op branch March 16, 2021 17:22
serhalp pushed a commit that referenced this pull request Apr 5, 2024
* refactor: create `src/build/functions/edge` directory

* feat: remove lookaheads from matchers

* feat: add routing logic to matchers

* chore: add test

* refactor: move things around and add test

* refactor: remove check for Netlify Dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants