fix: next 10.0.8 changes loadConfig to be async #105
Merged
+568
−627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
approved these changes
Mar 4, 2021
|
I think you implied this @lindsaylevine, but just to confirm:
|
lindsaylevine
force-pushed
the
ll/fix-10.0.8-async-load-config
branch
from
b46de96 to
04cfb47
Compare
lindsaylevine
commented
Mar 7, 2021
jlengstorf
approved these changes
Mar 8, 2021
| @@ -26,9 +26,11 @@ const transformManifestForI18n = (manifest) => { | |||
| return { ...manifest, routes: newRoutes } | |||
There was a problem hiding this comment.
not for now, but if we Promise.all these we'll get slightly better perf
const promises = items.map(async (item) => {
return await thing(item);
})
await Promise.all(items);
// continuenot a dealbreaker by any means, but something that might help us eke some extra ms out of this
lindsaylevine
commented
Mar 8, 2021
lindsaylevine
added a commit
that referenced
this pull request
Mar 8, 2021
* foundation: embed NoN into plugin under src/ * wip: updates to test paths, but things still aren’t working * fix: use next@^10.0.6 for i18n * 3.0.0@canary.1 release * wip: start changelog entry for review * chore: update version + installation instructions * fix: edit for clarity Co-authored-by: rstavchansky <rachael@netlify.com> * fix: add link + edit for clarity Co-authored-by: rstavchansky <rachael@netlify.com> * fix: add UI-based install back in * fix: add NoN migration guide link * fix: include src in published package * 3.0.0@canary.2 release * fix: package description * fix: next 10.0.8 changes loadConfig to be async (#105) * fix: 10.0.8 changes loadConfig to be async * wip: make literally everything async bc loadConfig * wip: fix i18n bug, got 10.0.6 tests to pass * wip: NoN tests pass on 10.0.8 but plugin test chdir fixture issue * Fix bug with Jest * fix: delete TO-DO Co-authored-by: ehmicky <ehmicky@gmail.com> Co-authored-by: Lindsay Levine <lindslev.ll@gmail.com> Co-authored-by: rstavchansky <rachael@netlify.com> Co-authored-by: lindsaylevine <57350178+lindsaylevine@users.noreply.github.com> Co-authored-by: ehmicky <ehmicky@gmail.com>
lindsaylevine
added a commit
that referenced
this pull request
Mar 8, 2021
- feat: merge `next-on-netlify` into `@netlify/plugin-nextjs` This improves our ability to maintain the plugin, reduces confusion about how to configure Next.js support for Netlify builds, and prepares the plugin for something we're pretty dang excited about: automatic installation for new Next.js projects! > **NOTE: There are no breaking changes for existing plugin users.** This is a major release because we're bringing an external package into the plugin _and_ turning on automatic installation for new Next.js projects on Netlify. This doesn't break anything, but it's a big enough change that we wanted to treat it as a major release. - fix: next 10.0.8 changes loadConfig to be async ([#105](#105))
This was referenced Mar 12, 2021
serhalp
pushed a commit
that referenced
this pull request
Apr 5, 2024
…rendered content (#105) * feat: use publish dir constant when getting middlewareManifest * feat: better error checking when copying static content * feat: simply static content copying * chore: better variable names for copying server content * feat: rework prerendered content method * chore: simplify static content logic * fix: normalize prerendered index routes * fix: explicity add prerendered not found routes * feat: better guard against wrongly unpublishing static on failed builds * fix: don't attempt to copy app router 404 page on page router site * chore: fix static content tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #104
this means that sites using =>10.0.8 will be incompatible with plugin <= 2.0.1
BUT
sites using <=10.0.7 using plugin > 2.0.1 will still work at least 🙃