fix: remove temp publish dir before moving static content (#278)

Author: orinokai

src/build/content/static.ts

@@ -60,8 +60,9 @@ export const copyStaticAssets = async (ctx: PluginContext): Promise<void> => {
  */
 export const publishStaticDir = async (ctx: PluginContext): Promise<void> => {
   try {
-    await mkdir(ctx.resolve('.netlify/.next'), { recursive: true })
-    await rename(ctx.publishDir, ctx.resolve('.netlify/.next'))
+    await rm(ctx.tempPublishDir, { recursive: true, force: true })
+    await mkdir(ctx.tempPublishDir, { recursive: true })
+    await rename(ctx.publishDir, ctx.tempPublishDir)
     await rename(ctx.staticDir, ctx.publishDir)
   } catch (error) {
     ctx.failBuild('Failed publishing static content', error instanceof Error ? { error } : {})
@@ -73,9 +74,9 @@ export const publishStaticDir = async (ctx: PluginContext): Promise<void> => {
  */
 export const unpublishStaticDir = async (ctx: PluginContext): Promise<void> => {
   try {
-    if (existsSync(ctx.resolve('.netlify/.next'))) {
+    if (existsSync(ctx.tempPublishDir)) {
       await rename(ctx.publishDir, ctx.staticDir)
-      await rename(ctx.resolve('.netlify/.next'), ctx.publishDir)
+      await rename(ctx.tempPublishDir, ctx.publishDir)
     }
   } catch {
     // ignore

src/build/plugin-context.ts

@@ -37,6 +37,11 @@ export class PluginContext {
     return this.constants.PUBLISH_DIR ?? join(this.packagePath, DEFAULT_PUBLISH_DIR)
   }
 
+  /** Temporary directory for stashing the build output */
+  get tempPublishDir(): string {
+    return this.resolve('.netlify/.next')
+  }
+
   /** Absolute path of the publish directory */
   get publishDir(): string {
     // Does not need to be resolved with the package path as it is always a repository absolute path