-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
fix: preview show error stack trace #6281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: preview show error stack trace #6281
Conversation
@erezrokah Please explain the further procedure. Sorry for being so silly. |
Thanks @devnamrits, give me some time to test this. You can look at other issues if you'd like |
@erezrokah |
@devnamrits, looks like some CI tests are failing, can you look into it? |
@erezrokah Looking into this. |
@erezrokah Created a new state variable named as errorTitle because while creating the issue URL we're using just errorMessage rather than using the whole error stack. Also since we're generating snapshots for tests we run. In the case of ErrorBoundary.js, we're generating a snapshot of the error UI which will contain the error trace. So the snapshots will contain those error traces as well which will vary from user to user due to different local directory configurations. Hence, after updating test snapshots, all tests are passing. |
46b26f4
to
51d62f6
Compare
9633c67
to
1759be9
Compare
Thanks for this @devnamrits, I removed the snapshot validation as it does more harm than good in this case. |
Closes #5907 #4070
Summary:
It will elaborately describe the error by showing the stack trace of the error.
As of now, only the error message is being shown in the UI which makes it difficult to debug things in the app.
Test plan

Checklist
Please add a
x
inside each checkbox:yarn format
.yarn test
.