fix: if the purge api call fails, include the api response body in the thrown error's message #571
+69
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e thrown error's message
…the purge api Prior to this commit, a call to `purgeCache` could supply any combination of siteID, siteSlug, and domain. If that does happen then the purge api endpoint as of today will do the following: - If the request passed in SiteID and either SiteSlug or Domain, then the SiteID would be used - If the request passed in SiteSlug and Domain, then the SiteSlug would be used This is likely not what the user is wanting. I've opened a pull-request in netlify-server to make it return an error response instead, but I think we can also improve the situation in this package by throwing an earlier error, one which they the user can spot when developing locally
rybit
approved these changes
Mar 4, 2025
JakeChampion
pushed a commit
that referenced
this pull request
Mar 17, 2025
🤖 I have created a release *beep* *boop* --- ## [3.0.2](v3.0.1...v3.0.2) (2025-03-17) ### Bug Fixes * if the purge api call fails, include the api response body in the thrown error's message ([#571](#571)) ([e01516d](e01516d)) * only purge alias by default if the purgeCache function is called within a deployed function ([#576](#576)) ([964b0a2](964b0a2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: token-generator-app[bot] <82042599+token-generator-app[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now if the purge call returns a non-ok response, the error message does not include the response, which makes it hard for the user of the api to figure out what the issue is