This repository was archived by the owner on Jan 11, 2023. It is now read-only.
fix: updated Remix framework info that was missing #836
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for framework-info ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
nickytonline
commented
Nov 9, 2022
| @@ -3,12 +3,14 @@ | |||
| "name": "Remix", | |||
| "category": "static_site_generator", | |||
| "detect": { | |||
| "npmDependencies": ["remix", "@remix-run/netlify"], | |||
| "npmDependencies": ["remix", "@remix-run/netlify", "@remix-run/netlify-edge"], | |||
There was a problem hiding this comment.
"@remix-run/netlify-edge" does not exist yet, but it will soon.
There was a problem hiding this comment.
Actually, quick question about npmDependencies. It means it needs to include all of them correct? So since we'll have a netlify-edge dep soon, should I create a remix-edge.json or just have npmDependencies contain only remix?
There was a problem hiding this comment.
OK, so in the ReadME, I confirmed that only one of them needs to be present to be considered the framework. https://github.com/netlify/framework-info#npmdependencies
npmDependencies
Type: string[]
Framework's npm packages. Any project with one of those packages in their package.json (dependencies or devDependencies) will be considered as using the framework.
If empty, this is ignored.
ascorbic
suggested changes
Nov 10, 2022
ascorbic
approved these changes
Nov 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Adds missing framework info for Remix.
Fixes #835
Relates to remix-run/remix#3104
For us to review and ship your PR efficiently, please perform the following steps:
ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a
typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)