fix(deploy): fix edge function logs url scope key #6881
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to #6851. You can see here it says "Show logs for deploy...": https://app.netlify.com/sites/hydrogen-advanced-caching/logs/ edge-functions?scope=deployid:6705473738103f2856071dbd. This doesn't work with `?scope=deploy:` This is a bit of a footgun since the Functions log URL takes `deploy:` but the Edge Functions log URL takes `deployid:`.
mrstork
reviewed
Oct 17, 2024
| @@ -536,7 +536,7 @@ const runDeploy = async ({ | |||
|
|
|||
| if (!deployToProduction) { | |||
| functionLogsUrl += `?scope=deploy:${deployId}` | |||
| edgeFunctionLogsUrl += `?scope=deploy:${deployId}` | |||
| edgeFunctionLogsUrl += `?scope=deployid:${deployId}` | |||
There was a problem hiding this comment.
Maybe we do a follow-up PR to make these two match? Personally I like the deploy naming a bit more.
There was a problem hiding this comment.
The downside is we'd effectively have to support both keys forever. Well, maybe not forever, but we'd have to do a two-phase change with several months in between.
mrstork
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #6851.
You can see here it says "Show logs for deploy...": https://app.netlify.com/sites/hydrogen-advanced-caching/logs/edge-functions?scope=deployid:6705473738103f2856071dbd.
This doesn't work with
?scope=deploy:.This is a bit of a footgun since the Functions log URL takes
deploy:but the Edge Functions log URL takesdeployid:. 😓