feat: pass accountId to resolveConfig #6733
Merged
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielSLew
previously approved these changes
Jun 25, 2024
📊 Benchmark resultsComparing with 37d8193
|
DanielSLew
previously approved these changes
Jun 25, 2024
khendrikse
reviewed
Jun 26, 2024
| @@ -685,6 +687,7 @@ export default class BaseCommand extends Command { | |||
|
|
|||
| try { | |||
| return await resolveConfig({ | |||
| accountId: this.accountId, | |||
There was a problem hiding this comment.
I'm curious how we know we'll have accountId on this?
There was a problem hiding this comment.
I share your curiosity because we do the same for siteId, but it seems to work, let me see
There was a problem hiding this comment.
ah I understand, because we assign it to the actionCommand which is of type BaseCommand. This means that anything assigned to it will be available on this when the command is run. Happy I understand it now.
fwiw I tried just assigning it to this in the baseCommand itself but it doesn't persist
…ture-flags-to-netlifyconfig-v2
khendrikse
approved these changes
Jun 26, 2024
lemusthelroy
deleted the
lemusthelroy/cpla-1291-ensure-cli-passes-feature-flags-to-netlifyconfig-v2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Passes
accountIdtoresolveConfig()which is going to be used when fetching build eventsFor us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)