Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use the right Blobs context in serve #6507

Merged
merged 2 commits into from Apr 10, 2024
Merged

Conversation

eduardoboucas
Copy link
Member

Summary

netlify serve is a bit special in that it first runs a build and then starts a server. In production, these steps have different Blobs contexts — API access should be used at build time and edge access should be used at runtime. This PR makes the serve command respect that.

Part of COM-580.

@eduardoboucas eduardoboucas requested a review from a team as a code owner April 10, 2024 10:27
Copy link

📊 Benchmark results

Comparing with 1908078

  • Dependency count: 1,313 (no change)
  • Package size: 294 MB ⬇️ 0.00% decrease vs. 1908078
  • Number of ts-expect-error directives: 1,007 ⬇️ 0.10% decrease vs. 1908078

@eduardoboucas eduardoboucas changed the title fix: use the right Blobs context in serve fix: use the right Blobs context in serve Apr 10, 2024
@eduardoboucas eduardoboucas merged commit a3ff3c6 into main Apr 10, 2024
72 checks passed
@eduardoboucas eduardoboucas deleted the fix/serve-blobs-2 branch April 10, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants