feat: load edge functions bootstrap from module #6496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardoboucas
commented
Apr 5, 2024
| @@ -30,7 +30,7 @@ import { featureFlags as edgeFunctionsFeatureFlags } from './edge-functions/cons | |||
| * @param {*} config.deployHandler | |||
| * @returns {BuildConfig} | |||
| */ | |||
| export const getBuildOptions = ({ | |||
| export const getBuildOptions = async ({ | |||
There was a problem hiding this comment.
Every call to this method is already using await, so this is fine.
Skn0tt
previously approved these changes
Apr 8, 2024
Skn0tt
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rather than having to manually update the version of the edge functions bootstrap every time there's a new release, this PR loads the bootstrap URL from the
@netlify/edge-functionsmodule. When there's a new version of the bootstrap, we'll release a new version of the module and Renovate will kick the usual update routine, meaning we'll have a semi-automated way of keeping the bootstrap up-to-date.