feat: add --internal-disable-edge-functions flag to skip Deno setup
#6495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seancdavis
previously requested changes
Apr 5, 2024
Co-authored-by: Sean C Davis <scdavis41@gmail.com>
Co-authored-by: Sean C Davis <scdavis41@gmail.com>
Co-authored-by: Sean C Davis <scdavis41@gmail.com>
Co-authored-by: Sean C Davis <scdavis41@gmail.com>
eduardoboucas
requested changes
Apr 8, 2024
src/commands/dev/dev.ts
Outdated
| @@ -271,6 +272,7 @@ export const createDevCommand = (program: BaseCommand) => { | |||
| .option('-d ,--dir <path>', 'dir with static files') | |||
| .option('-f ,--functions <folder>', 'specify a functions folder to serve') | |||
| .option('-o ,--offline', 'disables any features that require network access') | |||
| .option('--disable-edge-functions', "disables edge functions. use this if your environment doesn't support Deno") | |||
There was a problem hiding this comment.
I don't think we should treat this as a customer-facing flag. The only use case we have for it is purely internal, and we haven't fully considered the experience people will get if they disable edge functions. I suggest we use .hideHelp() here (example) so it's removed from the docs, and I would even consider renaming it to something like --internal-disable-edge-functions. That way we're not committing to indefinitely supporting something we're just exploring at this point.
There was a problem hiding this comment.
that's a very fair point. implemented in 6540b87
eduardoboucas
approved these changes
Apr 8, 2024
eduardoboucas
changed the title
--disable-edge-functions flag to skip Deno setup--internal-disable-edge-functions flag to skip Deno setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://linear.app/netlify/issue/COM-579/run-ntl-dev-without-the-need-for-deno.