Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace bad doc URL in output #6460

Merged
merged 1 commit into from Mar 26, 2024
Merged

fix: replace bad doc URL in output #6460

merged 1 commit into from Mar 26, 2024

Conversation

serhalp
Copy link
Contributor

@serhalp serhalp commented Mar 22, 2024

Summary

When the framework isn't detected, a message is printed to stdout. Currently, this includes a link to a page that provides no useful information about framework detection. This replaces the URL with an actionable one.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

image

@serhalp serhalp requested a review from a team as a code owner March 22, 2024 18:08
Copy link

github-actions bot commented Mar 22, 2024

📊 Benchmark results

Comparing with 577a6b5

  • Dependency count: 1,328 (no change)
  • Package size: 298 MB (no change)
  • Number of ts-expect-error directives: 1,029 (no change)

When the framework isn't detected, a message is printed to stdout. Currently, this includes a link
to a page that provides no useful information about framework detection. This replaces the URL with
an actionable one.
@serhalp
Copy link
Contributor Author

serhalp commented Mar 26, 2024

@netlify/ecosystem-pod-composable-tooling quick review?

Copy link
Contributor

@ndhoule ndhoule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@ndhoule ndhoule merged commit 31ef216 into main Mar 26, 2024
40 checks passed
@ndhoule ndhoule deleted the fix/replace-bad-doc-link branch March 26, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants