Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: a regression in ntl serve with the package path #6450

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Conversation

lukasholzer
Copy link
Collaborator

@lukasholzer lukasholzer commented Mar 18, 2024

πŸŽ‰ Thanks for submitting a pull request! πŸŽ‰

Summary

Fixes https://linear.app/netlify/issue/COM-549/monorepo-with-edge-functions-ssr-returning-404-since-cli-v-17193

Fixes a regression that was introduced with #6433


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code πŸ§‘β€πŸ’». This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire πŸ”₯ (e.g. incident related), you can skip this step.
  • Read the contribution guidelines πŸ“–. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) πŸ§ͺ
  • Update or add documentation (if features were changed or added) πŸ“
  • Make sure the status checks below are successful βœ…

A picture of a cute animal (not mandatory, but encouraged)

@lukasholzer lukasholzer requested a review from a team as a code owner March 18, 2024 10:23
Copy link

github-actions bot commented Mar 18, 2024

πŸ“Š Benchmark results

Comparing with 2c716d8

  • Dependency count: 1,326 (no change)
  • Package size: 298 MB ⬆️ 0.00% increase vs. 2c716d8
  • Number of ts-expect-error directives: 1,112 ⬇️ 0.72% decrease vs. 2c716d8

ascorbic
ascorbic previously approved these changes Mar 18, 2024
Copy link
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that this fixes the issue. Thanks

@lukasholzer lukasholzer enabled auto-merge (squash) March 18, 2024 10:47
@lukasholzer lukasholzer merged commit f10fb05 into main Mar 18, 2024
40 checks passed
@lukasholzer lukasholzer deleted the fix/COM-549 branch March 18, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants