feat(functions): add scheduled functions templates #4145

karagulamos · 2022-01-29T15:34:40Z

This PR is an update to the CLI function templates as follows

Added a scheduled-function template for Javascript
Added a scheduled-function template for TypeSecript

github-actions · 2022-01-29T15:35:22Z

📊 Benchmark results

Comparing with 49708c2

Package size: 363 MB

⬆️ 0.00% increase vs. 49708c2

^  360 MB  360 MB  360 MB  360 MB  360 MB  360 MB  360 MB  360 MB  360 MB  360 MB  360 MB  360 MB  363 MB 
│   ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T

Legend

T-30 (49708c2): 363 MB
T-29 (fa43ab8): 362 MB
T-28 (4ffba32): 362 MB
T-27 (fc1c991): 361 MB
T-26 (a7c6aab): 361 MB
T-25 (c2f4f1d): 361 MB
T-24 (cc2c6dd): 361 MB
T-23 (3d40fe1): 361 MB
T-22 (1fcb0e3): 361 MB
T-21 (e763556): 361 MB
T-20 (be0bb11): 361 MB
T-19 (d6d99d3): 361 MB
T-18 (d5d421d): 361 MB
T-17 (432774f): 360 MB
T-16 (93b64cf): 360 MB
T-15 (cd7af03): 360 MB
T-14 (c8281ec): 360 MB
T-13 (54040d8): 360 MB
T-12 (1981515): 360 MB
T-11 (434cdb7): 360 MB
T-10 (c89d81a): 360 MB
T-9 (0550e60): 360 MB
T-8 (f1c4d10): 360 MB
T-7 (50b3483): 360 MB
T-6 (df33dd0): 360 MB
T-5 (a41323f): 360 MB
T-4 (b2b0faa): 360 MB
T-3 (7d65669): 360 MB
T-2 (1c8968d): 360 MB
T-1 (40b1cf9): 360 MB
T (current commit): 363 MB

eduardoboucas

Nice one! Noted a couple of things that we should address, but otherwise looks good.

src/functions-templates/javascript/scheduled-function/package.json

src/functions-templates/javascript/scheduled-function/{{name}}.js

src/functions-templates/typescript/scheduled-function/package.json

src/functions-templates/typescript/scheduled-function/{{name}}.ts

…json Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com>

Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com>

…json Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com>

Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com>

src/functions-templates/javascript/scheduled-function/{{name}}.js

src/functions-templates/typescript/scheduled-function/{{name}}.ts

…ipt-typescript

src/functions-templates/javascript/scheduled-function/{{name}}.js

…ipt-typescript

feat: add SF template for javascript & typescript

4a69264

karagulamos added the type: feature label Jan 29, 2022

karagulamos requested a review from minivan January 29, 2022 15:34

karagulamos self-assigned this Jan 29, 2022

karagulamos requested a review from eduardoboucas January 29, 2022 15:36

karagulamos added the automerge label Jan 29, 2022

eduardoboucas requested changes Jan 31, 2022

View reviewed changes

karagulamos and others added 4 commits January 31, 2022 12:27

Update src/functions-templates/javascript/scheduled-function/package.…

69e68dc

…json Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com>

Update src/functions-templates/javascript/scheduled-function/{{name}}.js

3a6dc95

Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com>

Update src/functions-templates/typescript/scheduled-function/package.…

4072e61

…json Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com>

Update src/functions-templates/typescript/scheduled-function/{{name}}.ts

9be2262

Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com>

minivan previously approved these changes Jan 31, 2022

View reviewed changes

src/functions-templates/javascript/scheduled-function/{{name}}.js Outdated Show resolved Hide resolved

fix: applied suggested improvements

2dc788e

karagulamos dismissed minivan’s stale review via 2dc788e January 31, 2022 12:20

eduardoboucas reviewed Jan 31, 2022

View reviewed changes

src/functions-templates/typescript/scheduled-function/{{name}}.ts Outdated Show resolved Hide resolved

karagulamos added 4 commits January 31, 2022 14:30

fix: prefer inferred types over explicit ones

86b580a

chore: add helpful comments to SF-JS template

9b25b53

chore: add helpful comments to SF-TS template

2be9f32

Merge branch 'main' into feat/add-scheduled-function-template-javsacr…

34be08a

…ipt-typescript

eduardoboucas reviewed Feb 2, 2022

View reviewed changes

src/functions-templates/javascript/scheduled-function/{{name}}.js Outdated Show resolved Hide resolved

src/functions-templates/javascript/scheduled-function/{{name}}.js Outdated Show resolved Hide resolved

karagulamos and others added 2 commits February 2, 2022 18:56

chore: provide meaningful comments and examples

3055019

Merge branch 'main' into feat/add-scheduled-function-template-javsacr…

aec8c8d

…ipt-typescript

erezrokah changed the title ~~feat: add SF template for javascript & typescript~~ feat(functions): add scheduled functions templates Feb 4, 2022

eduardoboucas approved these changes Feb 4, 2022

View reviewed changes

kodiakhq bot added 2 commits February 4, 2022 12:31

Merge branch 'main' into feat/add-scheduled-function-template-javsacr…

564afe2

…ipt-typescript

Merge branch 'main' into feat/add-scheduled-function-template-javsacr…

9ce47ea

…ipt-typescript

kodiakhq bot merged commit 045326c into main Feb 4, 2022

kodiakhq bot deleted the feat/add-scheduled-function-template-javsacript-typescript branch February 4, 2022 12:47

token-generator-app bot mentioned this pull request Feb 4, 2022

chore(main): release 8.16.0 #4176

Merged

erezrokah mentioned this pull request Feb 4, 2022

test(command-functions): update to match templates #4177

Merged

5 tasks

token-generator-app bot mentioned this pull request May 26, 2022

chore(main): release 10.3.3 #4629

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(functions): add scheduled functions templates #4145

feat(functions): add scheduled functions templates #4145

karagulamos commented Jan 29, 2022 •

edited

Loading

github-actions bot commented Jan 29, 2022 •

edited

Loading

eduardoboucas left a comment

feat(functions): add scheduled functions templates #4145

feat(functions): add scheduled functions templates #4145

Conversation

karagulamos commented Jan 29, 2022 • edited Loading

github-actions bot commented Jan 29, 2022 • edited Loading

📊 Benchmark results

Package size: 363 MB

eduardoboucas left a comment

Choose a reason for hiding this comment

karagulamos commented Jan 29, 2022 •

edited

Loading

github-actions bot commented Jan 29, 2022 •

edited

Loading