-
Notifications
You must be signed in to change notification settings - Fork 392
fix: ignore function files with .ZIP extension #4003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kodiakhq
merged 11 commits into
netlify:main
from
karagulamos:fix/function-serve-ignore-zip-file
Jan 12, 2022
Merged
fix: ignore function files with .ZIP extension #4003
kodiakhq
merged 11 commits into
netlify:main
from
karagulamos:fix/function-serve-ignore-zip-file
Jan 12, 2022
+11
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardoboucas
previously approved these changes
Jan 11, 2022
Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com>
eduardoboucas
approved these changes
Jan 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4001
When serving functions via
netlify functions:serve
, the functions registry incorrectly loads function bundles (i.e. zip archive) created by netlify/zip-it-and-ship-it#637. This results in a cryptic and unrecoverable error when we try to access the functions.This fix ensures the registry ignores function bundles and logs a helpful message to the console.
@eduardoboucas