fix: identity default for function:invoke w/o arg #3971
Merged
+24
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com>
eduardoboucas
approved these changes
Jan 10, 2022
|
@eduardoboucas can we merge and release this? |
karagulamos
deleted the
fix/function-invoke-infer-default-value-for-identity-headers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3954
The fix eliminates the prompt that users of the Netlify CLI get when calling the
functions:invokecommand without identity header flags (i.e.--identityand--no-identity). In addition, when thefunctions:invokeis called without an identity flag, a--no-identitydefault is assumed.Although now redundant, I started with a simple test to validate that we receive a response from the function when no identity flag is passed. However, I left it in the code to catch regressions should requirements change in the future.