-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove unused --name
flag
#3766
Merged
Merged
+0
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Benchmark resultsComparing with 16712b7 Package size: 358 MB⬇️ 0.00% decrease vs. 16712b7
Legend
|
@lukasholzer I'll hold this PR open until #3717 is merged, so you don't get any weird conflicts because of it. |
@netlify-team-account-1 I will take over this and migrate it to the new commander framework |
0a741d4
to
7bb109a
Compare
I can't find a single usage of the flag. Maybe a remnant from some copy & paste?
7bb109a
to
7d665a0
Compare
erezrokah
approved these changes
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: command: functions
automerge
Add to Kodiak auto merge queue
type: feature
code contributing to the implementation of a feature and/or user facing functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing #3717, I wondered what the
--name
flag ofntl functions:list
does. Looking through the code, I can't find a single usage of the flag. Maybe it's a remnant from some copy & paste.Technically we remove a flag, which would be a breaking change - but since it doesn't do anything, I think it's fine to assume nobody uses it. Is it still a breaking change?