Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency @netlify/plugin-edge-handlers to v3 #3754

Merged
merged 1 commit into from
Dec 16, 2021

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 2, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@netlify/plugin-edge-handlers ^2.0.0 -> ^3.0.0 age adoption passing confidence

Release Notes

netlify/netlify-plugin-edge-handlers

v3.0.0

Compare Source

⚠ BREAKING CHANGES
Miscellaneous Chores

Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by WhiteSource Renovate. View repository job log here.

Sorry, something went wrong.

@github-actions github-actions bot added the type: bug code to address defects in shipped code label Dec 2, 2021
kodiakhq[bot]
kodiakhq bot previously approved these changes Dec 2, 2021
@github-actions
Copy link

github-actions bot commented Dec 2, 2021

📊 Benchmark results

Comparing with 95164c7

Package size: 354 MB

⬇️ 0.02% decrease vs. 95164c7

^                          363 MB  363 MB  363 MB  363 MB  363 MB  363 MB  363 MB  363 MB  363 MB  354 MB 
│  354 MB  354 MB  354 MB   ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐  
│   ┌──┐    ┌──┐    ┌──┐    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    
Legend

@ehmicky ehmicky self-requested a review December 2, 2021 14:03
Copy link
Contributor

@ehmicky ehmicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NeoLegends This is using the new version of @netlify/plugin-edge-handlers which uses pure ES modules (netlify/netlify-plugin-edge-handlers#689).

Netlify CLI is resolving the absolute file path to that plugin's CLI file.

const EDGE_HANDLERS_BUNDLER_CLI_PATH = path.resolve(require.resolve('@netlify/plugin-edge-handlers'), '..', 'cli.js')

Then it passes it to the --bundler argument of @netlify/routing-local-proxy's binary.

'--bundler',
EDGE_HANDLERS_BUNDLER_CLI_PATH,

Note: pure ES modules require Node 12.20.0, 14.14.0, 16.0.0 or higher.

The automated tests seem to pass but could you please confirm whether this should work with @netlify/routing-local-proxy before we merge this PR? Thanks!

@ehmicky ehmicky added type: chore work needed to keep the product and development running smoothly and removed type: bug code to address defects in shipped code labels Dec 2, 2021
@ehmicky ehmicky requested a review from NeoLegends December 2, 2021 14:10
@renovate renovate bot force-pushed the renovate/netlify-plugin-edge-handlers-3.x branch from b3550d7 to be7a406 Compare December 2, 2021 15:47
kodiakhq[bot]
kodiakhq bot previously approved these changes Dec 2, 2021
@renovate renovate bot force-pushed the renovate/netlify-plugin-edge-handlers-3.x branch from be7a406 to 0df8dc1 Compare December 2, 2021 16:15
kodiakhq[bot]
kodiakhq bot previously approved these changes Dec 2, 2021
@renovate renovate bot force-pushed the renovate/netlify-plugin-edge-handlers-3.x branch from 0df8dc1 to 1d9cf16 Compare December 2, 2021 17:02
kodiakhq[bot]
kodiakhq bot previously approved these changes Dec 2, 2021
@renovate renovate bot force-pushed the renovate/netlify-plugin-edge-handlers-3.x branch from 1d9cf16 to 20f16a7 Compare December 13, 2021 17:00
kodiakhq[bot]
kodiakhq bot previously approved these changes Dec 13, 2021
@renovate renovate bot force-pushed the renovate/netlify-plugin-edge-handlers-3.x branch from 20f16a7 to 28d36a8 Compare December 13, 2021 17:06
kodiakhq[bot]
kodiakhq bot previously approved these changes Dec 13, 2021
@github-actions github-actions bot added the type: bug code to address defects in shipped code label Dec 14, 2021
@renovate renovate bot force-pushed the renovate/netlify-plugin-edge-handlers-3.x branch from 28d36a8 to fd04dc6 Compare December 14, 2021 12:20
kodiakhq[bot]
kodiakhq bot previously approved these changes Dec 14, 2021
@renovate renovate bot force-pushed the renovate/netlify-plugin-edge-handlers-3.x branch from fd04dc6 to f38d10e Compare December 15, 2021 11:47
kodiakhq[bot]
kodiakhq bot previously approved these changes Dec 15, 2021
@renovate renovate bot force-pushed the renovate/netlify-plugin-edge-handlers-3.x branch from f38d10e to 7f6ad25 Compare December 15, 2021 12:14
kodiakhq[bot]
kodiakhq bot previously approved these changes Dec 15, 2021
@NeoLegends
Copy link
Contributor

Hey @ehmicky thanks for letting me know!

routing-local-proxy is spawning the cli.js by running node <CLI_PATH> build. For this to work node needs to know the CLI is an ES module. I believe it's working fine as it is since the plugin's package.json specifies "type": "module" and that makes nodejs load the file in an ES-compatible way automatically.

I ran a small test to confirm this behavior:

With "type": "module": image

Without "type": "module":
image

Alternatively we could change the file extension from the cli.js to cli.mjs to make sure node picks it up correctly even if it doesn't look at package.json for some reason.

@ehmicky
Copy link
Contributor

ehmicky commented Dec 15, 2021

Thanks for confirming this @NeoLegends!
The .mjs file extension should not be needed here since the package.json type: 'module' field should always be looked up by Node.js. If we are directly calling this file using node path/to/cli.js, then we should be good 👍

@ehmicky ehmicky added automerge Add to Kodiak auto merge queue and removed type: bug code to address defects in shipped code labels Dec 15, 2021
@ehmicky ehmicky self-requested a review December 15, 2021 17:16
Copy link
Contributor

@ehmicky ehmicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI tests are currently failing, but this is unrelated to this PR, since the main branch is currently failing as well.
Still, we should hold on merging until that test is fixed.

Edit: fixed now.

@ehmicky ehmicky added automerge Add to Kodiak auto merge queue and removed automerge Add to Kodiak auto merge queue labels Dec 16, 2021
@github-actions github-actions bot added the type: bug code to address defects in shipped code label Dec 16, 2021
@kodiakhq kodiakhq bot removed the automerge Add to Kodiak auto merge queue label Dec 16, 2021
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Dec 16, 2021

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

@renovate renovate bot force-pushed the renovate/netlify-plugin-edge-handlers-3.x branch from 663b3e1 to 57e2188 Compare December 16, 2021 16:37
@ehmicky ehmicky added automerge Add to Kodiak auto merge queue type: bug code to address defects in shipped code and removed type: bug code to address defects in shipped code labels Dec 16, 2021
@kodiakhq kodiakhq bot merged commit 475c9e6 into main Dec 16, 2021
@kodiakhq kodiakhq bot deleted the renovate/netlify-plugin-edge-handlers-3.x branch December 16, 2021 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Add to Kodiak auto merge queue type: bug code to address defects in shipped code type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants