-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update dependency @netlify/plugin-edge-handlers to v3 #3754
Conversation
📊 Benchmark resultsComparing with 95164c7 Package size: 354 MB⬇️ 0.02% decrease vs. 95164c7
Legend
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NeoLegends This is using the new version of @netlify/plugin-edge-handlers
which uses pure ES modules (netlify/netlify-plugin-edge-handlers#689).
Netlify CLI is resolving the absolute file path to that plugin's CLI file.
Line 17 in e227baa
const EDGE_HANDLERS_BUNDLER_CLI_PATH = path.resolve(require.resolve('@netlify/plugin-edge-handlers'), '..', 'cli.js') |
Then it passes it to the --bundler
argument of @netlify/routing-local-proxy
's binary.
Lines 37 to 38 in e227baa
'--bundler', | |
EDGE_HANDLERS_BUNDLER_CLI_PATH, |
Note: pure ES modules require Node 12.20.0
, 14.14.0
, 16.0.0
or higher.
The automated tests seem to pass but could you please confirm whether this should work with @netlify/routing-local-proxy
before we merge this PR? Thanks!
b3550d7
to
be7a406
Compare
be7a406
to
0df8dc1
Compare
0df8dc1
to
1d9cf16
Compare
1d9cf16
to
20f16a7
Compare
20f16a7
to
28d36a8
Compare
28d36a8
to
fd04dc6
Compare
fd04dc6
to
f38d10e
Compare
f38d10e
to
7f6ad25
Compare
Hey @ehmicky thanks for letting me know!
I ran a small test to confirm this behavior: Alternatively we could change the file extension from the |
Thanks for confirming this @NeoLegends! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI tests are currently failing, but this is unrelated to this PR, since the main
branch is currently failing as well.
Still, we should hold on merging until that test is fixed.
Edit: fixed now.
This PR currently has a merge conflict. Please resolve this and then re-add the |
663b3e1
to
57e2188
Compare
This PR contains the following updates:
^2.0.0
->^3.0.0
Release Notes
netlify/netlify-plugin-edge-handlers
v3.0.0
Compare Source
⚠ BREAKING CHANGES
Miscellaneous Chores
Configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by WhiteSource Renovate. View repository job log here.