Skip to content

feat: add a log message when we modify users .gitignore #2038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
erezrokah opened this issue Mar 22, 2021 · 1 comment · Fixed by #3595
Closed

feat: add a log message when we modify users .gitignore #2038

erezrokah opened this issue Mar 22, 2021 · 1 comment · Fixed by #3595
Assignees
@ngonsoto
Labels
area: command: init area: command: link good first issue type: feature code contributing to the implementation of a feature and/or user facing functionality

Comments

@erezrokah
Copy link
Contributor

erezrokah commented Mar 22, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.

See #2029 (comment)

Modifying users files without letting them know is not very nice. We should at least log that we're changing .gitignore

Describe the solution you'd like

When the CLI modifies .gitignore we should print a log message reflecting the change to the user

Describe alternatives you've considered

We could also prompt the user to approve/deny the change

Can you submit a pull request?

Yes
@erezrokah erezrokah added type: feature code contributing to the implementation of a feature and/or user facing functionality area: command: link area: command: init good first issue labels Mar 22, 2021
@ngonsoto
Copy link
Contributor

ngonsoto commented Nov 5, 2021

Hi @erezrokah, I would like to work on this issue.

ngonsoto pushed a commit to ngonsoto/cli that referenced this issue Nov 5, 2021
feat: add a prompt to modify users .gitignore (closes netlify#2038)
45b4cb0
@ngonsoto ngonsoto mentioned this issue Nov 5, 2021
Merged
5 tasks
ngonsoto pushed a commit to ngonsoto/cli that referenced this issue Dec 7, 2021
feat: add a log message when modifies .gitignore file (closes netlify…
8ed3e4b 
…#2038)
ngonsoto pushed a commit to ngonsoto/cli that referenced this issue Dec 7, 2021
feat: add a log message when modifies .gitignore file (closes netlify…
0a8ecb8 
…#2038)
ngonsoto pushed a commit to ngonsoto/cli that referenced this issue Dec 7, 2021
feat: add a log message when modifies .gitignore file (closes netlify…
7ea5b3f 
…#2038)
@kodiakhq kodiakhq bot closed this as completed in #3595 Dec 13, 2021
kodiakhq bot added a commit that referenced this issue Dec 13, 2021
@ngonsoto @kodiakhq
feat: add a prompt to modify users .gitignore (closes #2038) (#3595)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
96e28bf 
* feat: add a prompt to modify users .gitignore (closes #2038)

* feat: add a log message when modifies .gitignore file (closes #2038)

Co-authored-by: Nicolas Gonzalez <nico.fgs64@gmail.com>
Co-authored-by: Lukas Holzer <lukas.holzer@netlify.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ngonsoto ngonsoto

Labels
area: command: init area: command: link good first issue type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add a prompt to modify users .gitignore (closes netlify#2038) ngonsoto/cli
2 participants
@erezrokah @ngonsoto