Skip to content

Commit f3cc8cc

Browse files
Skn0ttbiruwon
andauthoredMay 29, 2024··
feat: propagate per-function timeout in deploy (#6676)
Co-authored-by: Antonio Rodríguez <antonio.rodriguez@netlify.com>
1 parent b0e512e commit f3cc8cc

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed
 

‎src/utils/deploy/hash-fns.ts

+2
Original file line numberDiff line numberDiff line change
@@ -169,6 +169,7 @@ const hashFns = async (
169169
runtime,
170170
runtimeVersion,
171171
trafficRules,
172+
timeout,
172173
}) => ({
173174
filepath: functionPath,
174175
root: tmpDir,
@@ -182,6 +183,7 @@ const hashFns = async (
182183
displayName,
183184
generator,
184185
invocationMode,
186+
timeout,
185187
buildData,
186188
priority,
187189
trafficRules,

‎src/utils/deploy/upload-files.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ const uploadFiles = async (api, deployId, uploadList, { concurrentUpload, maxRet
1717

1818
// @ts-expect-error TS(7006) FIXME: Parameter 'fileObj' implicitly has an 'any' type.
1919
const uploadFile = async (fileObj, index) => {
20-
const { assetType, body, filepath, invocationMode, normalizedPath, runtime } = fileObj
20+
const { assetType, body, filepath, invocationMode, normalizedPath, runtime, timeout } = fileObj
2121

2222
const readStreamCtor = () => body ?? fs.createReadStream(filepath)
2323

@@ -47,6 +47,7 @@ const uploadFiles = async (api, deployId, uploadList, { concurrentUpload, maxRet
4747
body: readStreamCtor,
4848
deployId,
4949
invocationMode,
50+
timeout,
5051
name: encodeURI(normalizedPath),
5152
runtime,
5253
}

2 commit comments

Comments
 (2)

github-actions[bot] commented on May 29, 2024

@github-actions[bot]

📊 Benchmark results

  • Dependency count: 1,235
  • Package size: 295 MB
  • Number of ts-expect-error directives: 989

github-actions[bot] commented on May 29, 2024

@github-actions[bot]

📊 Benchmark results

  • Dependency count: 1,235
  • Package size: 295 MB
  • Number of ts-expect-error directives: 989
Please sign in to comment.