fix: dont show warning message for toml-defined scheduled functions (#4162)

* chore: add reproduction test

co-authored-by: Alexander Karagulamos <alex-contractor@netlify.com>

* fix: respect netlify.toml-configured schedule

co-authored-by: Alexander Karagulamos <alex-contractor@netlify.com>

* refactor: prevent user-provided netlify-toml from being injected into ZISI

* fix: test

Co-authored-by: Netlify Team Account 1 <netlify-team-account-1@users.noreply.github.com>
Co-authored-by: Alexander Karagulamos <alex-contractor@netlify.com>

Author: netlify-team-account-1

src/commands/functions/functions-invoke.js

@@ -156,7 +156,7 @@ const functionsInvoke = async (nameArgument, options, command) => {
     console.warn(`${NETLIFYDEVWARN} "port" flag was not specified. Attempting to connect to localhost:8888 by default`)
   const port = options.port || DEFAULT_PORT
 
-  const functions = await getFunctions(functionsDir)
+  const functions = await getFunctions(functionsDir, config)
   const functionToTrigger = await getNameFromArgs(functions, options, nameArgument)
   const functionObj = functions.find((func) => func.name === functionToTrigger)
 

src/utils/functions/get-functions.js

@@ -13,7 +13,14 @@ const addFunctionProps = ({ mainFile, name, runtime, schedule }) => {
 
 const JS = 'js'
 
-const getFunctions = async (functionsSrcDir) => {
+/**
+ * @param {Record<string, { schedule?: string }>} functionConfigRecord
+ * @returns {Record<string, { schedule?: string }>}
+ */
+const extractSchedule = (functionConfigRecord) =>
+  Object.fromEntries(Object.entries(functionConfigRecord).map(([name, { schedule }]) => [name, { schedule }]))
+
+const getFunctions = async (functionsSrcDir, config = {}) => {
   if (!(await fileExistsAsync(functionsSrcDir))) {
     return []
   }
@@ -22,6 +29,7 @@ const getFunctions = async (functionsSrcDir) => {
   // eslint-disable-next-line node/global-require
   const { listFunctions } = require('@netlify/zip-it-and-ship-it')
   const functions = await listFunctions(functionsSrcDir, {
+    config: config.functions ? extractSchedule(config.functions) : undefined,
     parseISC: true,
   })
   const functionsWithProps = functions.filter(({ runtime }) => runtime === JS).map((func) => addFunctionProps(func))

tests/command.functions.test.js

@@ -643,6 +643,29 @@ test('should serve helpful tips and tricks', async (t) => {
   })
 })
 
+test('should detect netlify-toml defined scheduled functions', async (t) => {
+  await withSiteBuilder('site-with-netlify-toml-ping-function', async (builder) => {
+    await builder
+      .withNetlifyToml({
+        config: { functions: { directory: 'functions', 'test-1': { schedule: '@daily' } } },
+      })
+      .withFunction({
+        path: 'test-1.js',
+        handler: async () => ({
+          statusCode: 200,
+        }),
+      })
+      .buildAsync()
+
+    await withDevServer({ cwd: builder.directory }, async (server) => {
+      const stdout = await callCli(['functions:invoke', 'test-1', `--port=${server.port}`], {
+        cwd: builder.directory,
+      })
+      t.is(stdout, '')
+    })
+  })
+})
+
 test('should detect file changes to scheduled function', async (t) => {
   await withSiteBuilder('site-with-isc-ping-function', async (builder) => {
     await builder