fix: avoid starting and stopping spinner loops (#7131)

This was a small regression introduced in #7026.

I didn't quite map the previous lib's API to nanospinner's correctly.

The intent here is to manually control each frame render and each clear. Instead, the
spinner here was already started before it's passed in to this method, then it was cleared
and started again on each chunk - but `start()` here would start a new interval loop and
set up new node.js exit listeners but `clear()` wouldn't clear them (`reset()` does that).

This was leading to unnecessary resource utilization and printing warnings like this:

```
MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 SIGINT listeners added to [process]. MaxListeners is 10. Use emitter.setMaxListeners() to increase limit
(Use node --trace-warnings ... to show where the warning was created)
(node:61086) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 SIGTERM listeners added to [process]. MaxListeners is 10. Use emitter.setMaxListeners() to increase limit
```

The fix here is to just manually render a single frame (`.spin()`) at a time (and `stop()`
the initial loop).

Author: serhalp

src/utils/shell.ts

@@ -4,7 +4,7 @@ import execa from 'execa'
 // @ts-expect-error TS(7016) FIXME: Could not find a declaration file for module 'stri... Remove this comment to see the full error message
 import stripAnsiCc from 'strip-ansi-control-characters'
 
-import type { Spinner } from '../lib/spinner.js'
+import { stopSpinner, type Spinner } from '../lib/spinner.js'
 import { chalk, log, NETLIFYDEVERR, NETLIFYDEVWARN } from './command-helpers.js'
 import { processOnExit } from './dev.js'
 
@@ -57,16 +57,19 @@ export const runCommand = (
     cwd,
   })
 
-  // This ensures that an active spinner stays at the bottom of the commandline
+  // Ensure that an active spinner stays at the bottom of the commandline
   // even though the actual framework command might be outputting stuff
+  if (spinner?.isSpinning) {
+    // The spinner is initially "started" in the usual sense (rendering frames on an interval).
+    // In this case, we want to manually control when to clear and when to render a frame, so we turn this off.
+    stopSpinner({ error: false, spinner })
+  }
   const pipeDataWithSpinner = (writeStream: NodeJS.WriteStream, chunk: any) => {
     if (spinner?.isSpinning) {
       spinner.clear()
     }
     writeStream.write(chunk, () => {
-      if (spinner?.isSpinning) {
-        spinner.start()
-      }
+      spinner?.spin()
     })
   }