Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add node 22 to supported runtime versions list #5917

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

mrstork
Copy link
Contributor

@mrstork mrstork commented Dec 4, 2024

Summary

Related to FRB-1505
Adds node v22 to the allowed runtime versions
If a user is using v22 via .nvmrc, once this is released their runtime version will match
Also supports the future default version being bumped from v18 to v22


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures
    your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

Sorry, something went wrong.

@mrstork mrstork requested a review from a team as a code owner December 4, 2024 16:30
Copy link
Member

@eduardoboucas eduardoboucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the chore: prefix to feat: before merging, otherwise this won't trigger a release or be part of the change log.

@mrstork mrstork changed the title chore: add node 22 to supported runtime versions list feat: add node 22 to supported runtime versions list Dec 4, 2024
@mrstork mrstork enabled auto-merge (squash) December 10, 2024 18:19
@mrstork mrstork merged commit b62d01d into main Dec 10, 2024
39 checks passed
@mrstork mrstork deleted the support-node-22-in-lambdas branch December 10, 2024 20:14
@serhalp
Copy link
Contributor

serhalp commented Dec 10, 2024

@mrstork FYI I noticed that when this got squashed the message turned back to chore: so this isn't getting included in the release notes and isn't triggering a rebase of the release-please PR

@mrstork mrstork restored the support-node-22-in-lambdas branch December 10, 2024 22:02
mrstork added a commit that referenced this pull request Dec 10, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
This was referenced Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants